[Frontend] Add -public-autolink-library option #3353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foundation imports CoreFoundation with @_implementationOnly, so CoreFoundation's modulemap won't be read, and the dependent libraries of CoreFoundation will not be automatically linked when using static linking. For example, CoreFoundation depends on libicui18n and it's modulemap has `link "icui18n"` statement. If Foundation imports CoreFoundation with @_implementationOnly as a private dependency, the toolchain doesn't have CoreFoundation's modulemap and Foundation's swiftmodule doesn't import CoreFoundation. So the swiftc can't know that libicui18n is required. This new option will add LINK_LIBRARY entry in swiftmodule to specify dependent libraries (in the example case, Foundation's swiftmodule should have LINK_LIBRARY entry of libicui18n)
|
@kateinoigakukun are you seeing this same failure with XCTest on macOS locally? I'm not able to reproduce it on my x86 hardware, and the build fails much earlier with a different error on M1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of swiftlang#35936.
This should fix issues with Foundation builds on the
swiftwasmbranch.