Merge main 2023-06-11 #5511
Merged
Merge main 2023-06-11 #5511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table in IRGen. SIL Functions are serialized in canonical SIL before they have their final ABI adjusted for large function arguments. Large function argument ABI is adjusted to be indirect as part of the transition from canonical SIL to lowered SIL. This means that if we deserialize a function from another module in canonical SIL and attempt to call it in IRGen we will call it with the wrong ABI implying if we reference any fields of the type in the deinit we will most likely crash (among other potential issues). This patch fixes the issue by changing IRGen to not lazily deserialize the moveonly deinit table and its associated functions. Instead if we do not have our table already deserialized, we just call the function's deinit via the destroy value deinit table. rdar://110496872
The compiler knows (from a macro declaration) what freestanding macro role a macro implementation is expected to implement. Pass that through to the macro expansion code itself, rather than guessing based on the protocol conformances of the implementation type. We already use this approach with attached macros, so this is more of the same. Eliminates a crash and improves diagnostics when the freestanding macro role and its implementation are out of sync, fixing rdar://110418969.
Per SE-0397, a macro may only have a single freestanding macro role, otherwise we would have an ambiguity in how a particular freestanding macro would be expanded. Produce an error on such macro declarations. Fixes rdar://110178899.
…f 'without more context'
…#65984) * [Observation] Transition to peer macros instead of arbitrary members * [Observation] Lift the initializer requirement by utilizing init accessors for fully formed definite initialization * [Observation] Gate enabling of peer macros by flag * [Observation] Enable feature for InitAccessors in the observation tests * [Observation] Add tests to validate memberwise and definite initialization
…d595d547bdfa2b9bb4f0b1e [move-only] Do not attempt to lazily deserialize the moveonly deinit table in IRGen.
…anding-macro-role [Macros] Provide the freestanding macro role for expansion operations.
…rn types There is no reason to special-case `Void` to permit it. Rather, make this a syntactic rule. Thanks to Alex Hoppen for the suggestion.
…terfaces This allows us to continue to accept Swift interface files created with older versions of the Swift 5.9 compiler that emitted a spurious `-> ()` on non-expression macro declarations.
Updating docs with new CI triggers
__GNUC__ can be defined on Wasm targets as well, so we need to check __wasm__ first.
Stubs.cpp includes <sys/resource.h> which requires the emulation in wasi-libc
…s-in-current-context Sema: Reword diagnostics to say 'without a type annotation' instead of 'without more context'
…31b4569de6eb6f2d8dcd0ceeb9a538 [wasm][stdlib] Fix return-address strategy selection
…c40dacafff72d609d2b35f0941e69d [wasm][stdlib] Add -D_WASI_EMULATED_PROCESS_CLOCKS to CFLAGS
kateinoigakukun
force-pushed
the
katei/merge-main-2023-06-11
branch
from
b2999a1 to
f5f4b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.