Re-enable exclusivity checking when targeting __wasm__ #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
approved these changes
May 15, 2020
|
I'll keep it open for a bit, want to do another round of end-to-end tests with some packages before merging it. |
|
In cursory testing, I don't see any obvious regressions with the macOS installable. Merging as is 👍 (If there are any other issues, we'll catch it in the test suite and deal with it later. Merging it now to clean up the upstreaming efforts). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested upstream at apple#31693, exclusivity checking should work just fine in single-threaded environments. I also haven't noticed any issues in my local builds.