-
Notifications
You must be signed in to change notification settings - Fork 29
Automattic's Fork #3
base: master
Are you sure you want to change the base?
Conversation
Because we are sending stats to StatsD on an interval everything is a gauge even "counts" which are ever increasing. There's a current issue open for StatsD (statsd/statsd#324) which requests "absolute" counters which would solve this problem however until that's solved we have to use gauges and just apply derivative functions after the fact. Le Sigh.
Add a config to turn on reporting of node level index stats (e.g. docs per node) which defaults to false.
* Make indices reporter report cluster totals always. * Let indices reporter sum per index and report if requested. * Let indices reporter report per shard if requested.
…es not mean doc type
@xyu thanks for doing all this work and preparing a PR: this is awesome and we'd love to evaluate merging the changes. That said, this PR is difficult to review because it has too many commits which have different granularities and are about different logical changes. Please, consider doing the following:
Thanks! |
Right of course :) but seeing as there are some rather major changes that break backwards compatibility with both StatsD key names and perhaps with ES 0.90.x (untested) I wanted to see if Swoop would even be interested in this fork. Are there features you guys would like and other you would rather avoid and how concerned are you guys with backwards compatibility? |
@xyu I created the https://github.com/swoop-inc/elasticsearch-statsd-plugin/tree/v1x branch for your PRs to target. Once we are done with the integration there we can switch master to the new version. |
@xyu awesome work |
The newest version (v3.0.2) of java-statsd-client now supports doubles for guage value and gauge deltas, update ES StatsD Plugin to send doubles instead of longs for load averages. This resolves #1
Howdy,
First of all sorry about this huge pull request, mainly I wanted to get a conversation going to see if you guys would be interested in merging some of the stuff from Automattic's fork of your plugin back in. We've made some extensive changes but mainly this fork:
Let me know if you guys are interested in merging in any of these features from our fork.