This repository was archived by the owner on Apr 20, 2025. It is now read-only.
Drop byte_literal in favour of b'' #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @sybrenstuvel |
|
Looks good, thanks. Merged in 9f57740 Also thanks for the ping, don't hesitate to ping me a bit sooner next time ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74.
Changes at
tests/test_load_save_keys.pyare because%formatting doesn't work for bytes on Python 3 (until Py3.5). I checked correctness until tests passed, but I would like this to be reviewed for unwanted newlines that could be added to concatenation.