Skip to content

Fix NoneType exception in common_args check #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

csparker247
Copy link

@csparker247 csparker247 commented Feb 7, 2020

At the end of ExifTool.__init__, there's an iteration over the provided common_args even if it's None. This causes a NoneType is not iterable exception if nothing is provided. This fix iterates over the initialized self.common_args instead.

@csparker247
Copy link
Author

Totally forgot I had submitted this. Would it possible to merge this PR? I don't think it would cause problems with the upstream merge like #4 does.

@sylikc sylikc merged commit 44e2e4e into sylikc:master Apr 9, 2020
@csparker247
Copy link
Author

Thanks!

@csparker247 csparker247 deleted the fix-nonetype-exception branch April 9, 2020 13:02
@sylikc sylikc added the bug Something isn't working label May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants