Skip to content

Speed operations on large responses #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylikc merged 1 commit into from
Dec 30, 2022
Merged

Speed operations on large responses #61

sylikc merged 1 commit into from
Dec 30, 2022

Conversation

@prutschman
Copy link

@prutschman prutschman commented Dec 1, 2022

Keep a list of bytes instead of repeatedly appending (copying) to the bytes object.

@prutschman
Speed operations on large responses
2026c75 
Keep a list of bytes instead of repeatedly appending (copying) to the bytes
object.
@prutschman
Copy link
Author

prutschman commented Dec 1, 2022

Address #60

@sylikc
Copy link
Owner

sylikc commented Dec 17, 2022

I finally got a chance to understand the reverse() built-in function and how it works... that is a GREAT solution to the problem at hand, it's super fast to just return a reverse iterable instead of actually reversing the list. I think that is the optimal way to implement this check

@sylikc sylikc added bug Something isn't working enhancement New feature or request labels Dec 17, 2022
sylikc
sylikc reviewed Dec 30, 2022
View reviewed changes
exiftool/exiftool.py

# ======================================================================================================================

def _get_buffer_end(buffer_list: List[bytes], bytes_needed: int) -> bytes:
Copy link
Owner

@sylikc sylikc Dec 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adhering to the typing... the code is great!

sylikc added a commit that referenced this pull request Dec 30, 2022
@sylikc
Speed operations on large responses.
53f552d 
This PR addresses the append() operations and uses lists and reverse() to speed up getting exiftool output

Merge PR #61 by https://github.com/prutschman
@sylikc sylikc merged commit 2026c75 into sylikc:master Dec 30, 2022
@sylikc sylikc linked an issue Dec 30, 2022 that may be closed by this pull request
High CPU consumption when using "-b" with large embedded binary data #60
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylikc sylikc sylikc left review comments

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

High CPU consumption when using "-b" with large embedded binary data

2 participants

@prutschman @sylikc