Skip to content

Added new node public key #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Added new node public key #244

merged 2 commits into from
Nov 16, 2020

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Nov 13, 2020

Added new node public key to the node/info endpoint

@rg911 rg911 changed the title Added new node public key endpoint Added new node public key Nov 14, 2020
Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a description explaining that it's used for node link and delegate harvesting?

@fboucquez
Copy link
Contributor

About publicKey, nodePublicKey names. There are not good enough but we don't want to break too much.

The renames would need to be done in another PR until we have all the upgrades in place at least from server and rest.

https://github.com/nemtech/catapult-server/issues/110

What would it be good candidates from them? It seems like they have multiple uses.

Maaaybe:

  • publicKey => caPublicKey = coming from ca.pem.key file, the node main account public key, and certificate authority.
  • nodePublicKey = coming for node.pem.key file required for communication and delegate harvesting

@segfaultxavi
Copy link
Collaborator

Yes, definitely the description is missing :D

Regarding the names, I prefer names that are useful to the user, not based on where the property comes from.
For instance, I don't know if the user is familiar enough with the concept of Certificate Authority. Is this the key used for signing new blocks? Can we call it something like signingPublicKey or harvestingPublicKey?
Regarding nodePublicKey, this is also confusing, since all these keys are related to the node somehow. This is the key used to activate Delegated Harvesting, and it relates to TLS somehow, right? Can we call it something like communicationPublicKey, tlsPublicKey, transamissionPublicKey, networkPublicKey, ... ?

@fboucquez
Copy link
Contributor

Atm you cannot put description or summary next to a ref element. This will change in the next open api spec

OAI/OpenAPI-Specification#1514

Let's revisit this when 1) we rename the key fields according to what we agree on server/bootstrap/rest/etc
2) when we upgrade the open api spec eventually

@fboucquez fboucquez merged commit bf0519a into symbol:main Nov 16, 2020
@segfaultxavi
Copy link
Collaborator

Atm you cannot put description or summary next to a ref element. This will change in the next open api spec

Related: #233

rg911 added a commit that referenced this pull request Dec 8, 2020
* Updated lock secret endpoints

* Added transactions transferMosaicId filter

* Creating new version 0.10.1

* Added endpoints to get finalization proof at a given height or point

* Point to Epoch and redesigned routes

* Added DTOs

* Made epoch endpoint clearer

* Renamed a field, added some descriptions

* Update spec/core/finalization/schemas/MessageGroup.yml

Co-authored-by: Xavi Artigas <[email protected]>

* Update spec/core/finalization/routes/getFinalizationProofAtEpoch.yml

* Fixed missing index entries

* Updated epoch/point types

* Added transfer amount options to filter transfer transactions

* Updated transferMosaicId param description

Co-authored-by: Xavi Artigas <[email protected]>

* Typo

* Fixed filter type

* Improved search transactions endpoint description regarding alias resolution and addresses (#231)

Co-authored-by: Xavi Artigas <[email protected]>

* Removed id from namespace meta

This field has been moved to the top-level

https://github.com/nemtech/symbol-openapi/blob/main/spec/plugins/namespace/schemas/NamespaceInfoDTO.yml#L3

* unlocke account (#243)

* Added new node public key (#244)

* Merkle endpoints for state proof  (#240)

* POC merkle endpoints
Renamed Status to LockStatus enum

* Updated Merkle Info name and description

* Added missing endpoints

* Added missing params

* Add new block type (#247)

* Add new block type

* Added missing export

* Added Uint64 to simplify generation.

Co-authored-by: fernando <[email protected]>

* Added merkle tree schema (#248)

Co-authored-by: fboucquez <[email protected]>
Co-authored-by: Xavi Artigas <[email protected]>

* Added version to states (#252)

* Added missing failure status (#250)

* Added missing failure status

* Added a few more missing statuses

* Moved Roles types to a generic number (#258)

* Updated network types (#257)

* Finality proof fix (#253)

* Finality proof fix

* Updated signatureSchema desc

* Namespace Transaction required fields fix (#242)

On namespace transactions, duration or parent id is required, but not both at the same time. 

If required is in place, user (and generated code) would think that duration and parentid are always provided.

* Updated version and CHANGELOG.md (#254)

* Update CHANGELOG.md (#259)

Co-authored-by: Martin Ayora <[email protected]>
Co-authored-by: Travis CI User <[email protected]>
Co-authored-by: Roger Hernandez <[email protected]>
Co-authored-by: Xavi Artigas <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Martin Ayora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants