This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Open
Conversation
Member
|
Do you think there are going to be more settings than the HTTP code? Otherwise, I'd prefer to not use the options resolver and just pass a config value to the constructor of |
Member
Author
|
There was a reason -- iirc it might have been that the HTTP code is not a DI config, is is metadata. |
Member
|
I propose to remove the ConfigurableInterface and add a new BC break. However, the current PR doesn't do anything, as the http code option isn't used anywhere in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this POC PR is to explore the possiblity passing options to the defunct route handlers - the use case being allowing the redirect HTTP code to be passed to the adapter which creates the redirect route.
Intitially I tried to avoid BC breaks, but the requirement to add
$optionsto thehandleDefunctRoutesmethod breaks any chance of this. The role of the newConfigurableInterfaceis therefore up for debate.