[WIP] orm - entities and configuration #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| realpath(__DIR__ . '/Resources/config/doctrine-model') => 'Symfony\Cmf\Bundle\RoutingBundle\Model', | ||
| realpath(__DIR__ . '/Resources/config/doctrine-orm') => 'Symfony\Cmf\Bundle\RoutingBundle\Doctrine\Orm', | ||
| ) | ||
| ) |
There was a problem hiding this comment.
this is missing the arguments to know the container parameter names of the manager name and of the parameter that tells if orm is activated.
| @@ -37,6 +38,17 @@ public function build(ContainerBuilder $container) | |||
| ) | |||
| ); | |||
| } | |||
|
|
|||
| if (class_exists('Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass')) { | |||
There was a problem hiding this comment.
oh, i just noticed that we provide a orm mapping pass in corebundle so that we do not need to up the symfony and doctrine version too much. we should use Symfony\Cmf\Bundle\CoreBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass instead
|
does this PR supersede #122 ? |
|
i think just to be merged into /orm branch |
dbu
added a commit
that referenced
this pull request
Jul 30, 2013
[WIP] orm - entities and configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.