[WIP] ORM based dynamic routing

[matteocaberlotto]

This should be the code to start from

[matteocaberlotto]

I wont have much time next month, if there's no hurry i can keep on working on it.
left todo

• check coexistence phpcr with orm
• implement redirection
• removed duplicated/unused code

there's something wrong with functional tests setup i need to figure out

[dbu]

cool, thanks! i will have a good look at this and try to reduce code duplication. will ask a few questions in the code now.

there are some code style issues and such, but lets look at those in the end.

[dbu]

from the code below i understand you moved the route enhancer configuration under this node. what exactly for? to allow more than one dynamic router being configured at the same time? we could do that, but then we should move the information if its to be an orm or phpcr-odm router in there as well. how do you decide that right now? or do you have the extension load and enhance a dynamic router service defined by your application?

[matteocaberlotto]

i think you know better how to handle this...

i added those lines as child of 'dynamic' field of 'symfony_cmf_routing' (or 'cmf_..') into app/config/config.yml

    instances:
        - symfony_cmf_routing.orm.dynamic_router
        - symfony_cmf_routing.dynamic_router

the chain -> routers_by_id tells which router and priority, they are not all dynamic one but the dynamic should be setup by the extension if i understood correct.
should another field (say 'dynamic') be added to 'routers_by_id' to mark a router as dynamic? the provider info are into xml services config and this tells which repository should the router fetch from.

[dbu]

as solution for this issue, #112 is separating the route provider from the rest of the dynamic router. the configuration does not expect that you would want to run more than one dynamic router. i think that makes sense, people in most cases won't need both orm and phpcr routes at the same time. if they really do, they can still define their own dynamic router service in their application.

[dbu]

thanks a lot for this so far! i think we are quite on track.
i will take this PR and refactor some things in the bundle, then create a PR against your branch from that. the phpcr-odm stuff is doing some not elegant things that lead to too much code duplication.

[matteocaberlotto]

thanks you all too

[erichard]

Is someone still working on this PR ? I've started working on the ORM implementation too so maybe we can collaborate on it.

[dbu]

hi @erichard i started sorting things out, but got sidetracked by other things. steps to take imo are:

1. move Document/* classes to Model/ and use the mapping compiler pass for that folder. check if we need a Doctrine/Phpcr/ class extending the class in Model or if all fields of the class are storage agnostic
2. add orm mappings and check if we need Doctrine/Orm classes or if the generic models have all fields we need.

so essentially i want to keep database specific code to a minimum. the provider itself will be specific, and the xml mappings. if you want to work on 1, the essential documentation is in symfony/symfony-docs#2669

[dbu]

i just created #112 with the refactoring i had in mind. once that is merged, it should be a manageable junk of code to port from this PR into the new way of doing things. trickiest part is probably the bundle configuration.

[dbu]

see #122