-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update Entities to use Doctrine 2.6 types #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like a good idea! But let's not submit any pull request until #617 is merged. Thanks! |
Also we should replace the |
This proposal is now unlocked and ready for someone who wants to contribute to this project with this easy pick. Thanks! |
I guess If you need more details I can provide a PR with example implementation. |
Talk is cheap.. PR is here #659 but test failing due to the mentioned issue. |
Let's close this as "fixed". The JSON types are now used and the immutable date can't be used because of Symfony Forms. The related issue (symfony/symfony#9508) has been opened for more than 4 years, so this is more difficult to implement than it looks. Thanks! |
Thanks to symfony/symfony#22689
Comment
andPost
entities should now use the newdate time_immutable
type for their$publishedAt
property, so getters/setters should acceptDateTimeInterface
.If you agree, this should be an easy pick.
The text was updated successfully, but these errors were encountered: