Skip to content

Move BrowserKit to dev requirements? #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garak opened this issue Sep 15, 2017 · 3 comments
Closed

Move BrowserKit to dev requirements? #649

garak opened this issue Sep 15, 2017 · 3 comments
Labels
bug

Comments

@garak
Copy link
Contributor

garak commented Sep 15, 2017

I would propose a PR myself, but I want to be sure: is there any reason to keep "symfony/browser-kit" in "require" section of composer.json (instead of "require-dev")?
It looks like this application is never using anything in the Symfony\Component\BrowserKit namespace, so the only use I can see is for tests.
@yceruto
Copy link
Member

yceruto commented Sep 15, 2017

👍

@javiereguiluz
Copy link
Member

Nice catch. This definitely looks like a mistake. Thanks!

garak added a commit to garak/symfony-demo that referenced this issue Sep 19, 2017
@garak
Move browser-kit and css-selector to require-dev
77f0f04 
See symfony#649
garak added a commit to garak/symfony-demo that referenced this issue Sep 19, 2017
@garak
Move browser-kit and css-selector to require-dev
7db4af1 
See symfony#649
@garak garak mentioned this issue Sep 19, 2017
Merged
javiereguiluz added a commit that referenced this issue Sep 20, 2017
@javiereguiluz
minor #650 Move browser-kit and css-selector to require-dev (garak)
6d3cb7d 
This PR was merged into the master branch.

Discussion
----------

Move browser-kit and css-selector to require-dev

See #649

Commits
-------

7db4af1 Move browser-kit and css-selector to require-dev
@javiereguiluz
Copy link
Member

Fixed by #650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @garak @yceruto