-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
No .htaccess #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Commiting .htaccess is a bad practice, because it complicates deploy. However, it would be nice to have example config files for the most used web servers in the documentation. |
@dzuelke - as per @jkufner comment this is considered as a bad practise. Check Configuring a Web Server documentation section for an explanation and information on how you should configure your web server. Nevertheless you can use
Hope this helps and answers you concern. |
Actually a good point. As far as we have a "Deploy to Heroku" button in README, we should have a proper |
Yeah I'm mostly interested in having it work out of the box on as many setups as possible, as it's a demo app. I could easily do a PR with a Heroku specific config or something, but would rather not clutter the repo with a vendor specific thing (the demo right now is not working on Heroku, for other reasons as well, such as SensioDistributionBundle being gone which used to write the |
It's true that we don't care about However, I agree that this should work out-of-the-box on Heroku (unless that requires us to change our code). We already have an |
For that we'd need a separate |
Let's close this in favor of the automatic detection feature on Heroku proposed by David ... and we'll reopen this if that's not possible to implement for any reason. |
This PR was merged into the master branch. Discussion ---------- Require symfony/apache-pack package What about to add `symfony/apache-pack` to this project? We have had a few related issues about missing it: #1069, #1005, #711 . Basically, it's a really small package that just adds `.htaccess` file into public/ dir and that's it. It would help Apache users and does not do any harm to others I think, so why not have it out of the box? Commits ------- 9a2dad5 Require symfony/apache-pack package
There is currently no
.htaccess
file in place with rewrites that removeindex.php
, so out of the box, the demo doesn't work beyond the first page. Is that intentional?The text was updated successfully, but these errors were encountered: