Skip to content

Use @IsGranted annotation instead of @Security #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
voronkovich opened this issue Apr 29, 2018 · 2 comments
Closed

Use @IsGranted annotation instead of @Security #792

voronkovich opened this issue Apr 29, 2018 · 2 comments
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@voronkovich
Copy link
Contributor

Recently a new @IsGranted annotation was introduced. It's just a shortcut for the well-known @Security annotation. See: https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/Configuration/IsGranted.php
@javiereguiluz javiereguiluz added the good first issue Ideal for your first contribution! (some Symfony experience may be required) label Apr 30, 2018
@javiereguiluz
Copy link
Member

I think this could be a good idea to show the new annotation in action.

@dmerchier dmerchier mentioned this issue May 10, 2018
Closed
javiereguiluz added a commit that referenced this issue May 20, 2018
@javiereguiluz
minor #797 Use @IsGranted instead of @Security. (DevMDamien)
39796aa 
This PR was squashed before being merged into the master branch (closes #797).

Discussion
----------

Use @IsGranted instead of @Security.

As asked in issue #792, I replaced some `@Security("is_granted()")` annotations by `@IsGranted`.

Commits
-------

166ffcf Use @IsGranted instead of @Security.
@javiereguiluz
Copy link
Member

Fixed by #797.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javiereguiluz @voronkovich