Skip to content

SYMFONY_PHPUNIT_VERSION in the phpunit.xml.dist has no effect #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tristanbes opened this issue Jun 5, 2019 · 3 comments
Closed

SYMFONY_PHPUNIT_VERSION in the phpunit.xml.dist has no effect #992

tristanbes opened this issue Jun 5, 2019 · 3 comments

Comments

@tristanbes
Copy link

tristanbes commented Jun 5, 2019 •
edited
Loading

Hello,

It seems that <env name="SYMFONY_PHPUNIT_VERSION" value="7.1"/> contained in the phpunit.xml.dist has literally no effect on the PHPUnit version used instead of the version 7.1

Let's see for yourself on your Travis builds: https://travis-ci.org/symfony/demo/jobs/540800942#L637 where version 6.5.14 is used.

Commenting those 3 lines seems to fix this problem, reading the value from phpunit.xml.dist again.

Thanks @Kocal to help me tracking this down.
@tristanbes tristanbes changed the title SYMFONY_PHPUNIT_VERSION has no effect SYMFONY_PHPUNIT_VERSION in the phpunit.xml.dist has no effect Jun 5, 2019
@mbabker
Copy link

mbabker commented Jun 10, 2019

The bin/phpunit file (and probably phpunit.xml.dist) should be updated for the PHPUnit bridge changes in SF 4.3, which includes removing the lines you've highlighted. But, that's probably blocked right now by #998.

This was referenced Jun 11, 2019
Closed
Merged
javiereguiluz added a commit that referenced this issue Jun 11, 2019
@javiereguiluz
bug #1000 use phpunit 7.5 (dmaicher)
badac21 
This PR was merged into the master branch.

Discussion
----------

use phpunit 7.5

See #992

And I also updated to phpunit 7.5

Commits
-------

ab0b711 use phpunit 7.5
@dmaicher
Copy link
Contributor

@javiereguiluz so this one can also be closed? 😉 Was fixed by #1000

@javiereguiluz
Copy link
Member

Yes, closing as as fixed. Thanks!

sayjun0505 added a commit to sayjun0505/sym_proj that referenced this issue Apr 16, 2023
@sayjun0505
bug #1000 use phpunit 7.5 (dmaicher)
6138ce2 
This PR was merged into the master branch.

Discussion
----------

use phpunit 7.5

See symfony/demo#992

And I also updated to phpunit 7.5

Commits
-------

ab0b711 use phpunit 7.5
spider-yamet added a commit to spider-yamet/sym_proj that referenced this issue Apr 16, 2023
@spider-yamet
bug #1000 use phpunit 7.5 (dmaicher)
0dc221c 
This PR was merged into the master branch.

Discussion
----------

use phpunit 7.5

See symfony/demo#992

And I also updated to phpunit 7.5

Commits
-------

ab0b711 use phpunit 7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javiereguiluz @tristanbes @mbabker @dmaicher