revert fixtures db change #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great detective work! Thank you so much David. It's great to see all tests green again 💚 |
javiereguiluz
added a commit
that referenced
this pull request
Jun 11, 2019
This PR was merged into the master branch. Discussion ---------- revert fixtures db change This fixes #998 The issue was that the fixture db data contained user passwords using `argon2` encoder algo which is not implemented in php 7.1 afaik. So authentication failed in the tests. So this reverts the db changes done in 6c32238. Build is green now 😉 Commits ------- a3fb81b revert fixtures db change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #998
The issue was that the fixture db data contained user passwords using
argon2encoder algo which is not implemented in php 7.1 afaik. So authentication failed in the tests.So this reverts the db changes done in 6c32238.
Build is green now 😉