Skip to content

Update markdown #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

abdounikarim
Copy link
Contributor

Hello,

I remove the Markdown class which was used to convert markdown to html.
I used the markdown_to_html filter instead.

I run the tests after and hey still works.

@javiereguiluz
Copy link
Member

I like this! Thanks @abdounikarim.

However, we need to revert the changes related to tgalopin/html-sanitizer-bundle because we want to keep that bundle and its features. Thanks!

@javiereguiluz
Copy link
Member

I see now why you removed the HTML sanitizer bundle ... but instead of that ... we may add a new Twig filter to do this -> ... | sanitize_html I don't know which could be the best option here ... maybe @tgalopin can suggest us something. Thanks!

@javiereguiluz
Copy link
Member

After talking with Titouan, he told me that the Sanitizer bundle already provides a sanitize_html Twig filter ... so we may try to do the following:

  • Reinstall and reenable the HtmlSanitizer bundle as before
  • Tweak the needed Twig templates to add the |sanitize_html filter after the Markdown filter

@abdounikarim
Copy link
Contributor Author

After talking with Titouan, he told me that the Sanitizer bundle already provides a sanitize_html Twig filter ... so we may try to do the following:

  • Reinstall and reenable the HtmlSanitizer bundle as before
  • Tweak the needed Twig templates to add the |sanitize_html filter after the Markdown filter

@javiereguiluz done

@javiereguiluz
Copy link
Member

Thanks for this contribution Karim!

@javiereguiluz javiereguiluz merged commit 2bfa530 into symfony:master Mar 6, 2020
javiereguiluz added a commit that referenced this pull request Mar 12, 2020
This PR was merged into the master branch.

Discussion
----------

Replace twig and twig-bundle with twig-pack

This PR replace `twig/twig` and `symfony/twig-bundle` with `symfony/twig-pack` which also install `twig/extra-bundle` that is require since #1080 and the addition of `Twig\Extra\TwigExtraBundle\TwigExtraBundle::class` in `bundles.php`

It also bump symfony packages to `v5.0.5`

Commits
-------

68c7219 Replace twig and twig-bundle with twig-pack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants