Skip to content

Updated backend dependencies #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Updated backend dependencies #1152

merged 1 commit into from
Sep 12, 2020

Conversation

javiereguiluz
Copy link
Member

Dependencies were updated with Composer 2 RC1.

@@ -35,16 +35,13 @@ jobs:
include:
# Run tests with the dependencies from composer.lock
- php: 7.2
- php: 7.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so no tests on PHP 7.3 anymore ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No ... I thought that the lowest supported version (7.2) and the highest supported version (7.4) was enough. Do you agree?

@javiereguiluz
Copy link
Member Author

javiereguiluz commented Sep 10, 2020

I need help to debug the following issue in Travis. Thanks!

$ [[ $TRAVIS_PHP_VERSION != "7.4" ]] || ./vendor/bin/php-cs-fixer fix --diff --dry-run -v
PHP Fatal error:  Uncaught Error: Call to undefined method PhpCsFixer\Config::create() in /home/travis/build/symfony/demo/.php_cs.dist:23
Stack trace:
#0 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(931): include()
#1 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(227): PhpCsFixer\Console\ConfigurationResolver::separatedContextLessInclude('/home/travis/bu...')
#2 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(623): PhpCsFixer\Console\ConfigurationResolver->getConfig()
#3 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(456): PhpCsFixer\Console\ConfigurationResolver->getFormat()
#4 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/Command/FixCommand.php(154): PhpCsFixer\Console\ConfigurationResolver->getReporter()
#5 /home/travis/build/symfony/demo/vendor/symfony/console/Command/Co in /home/travis/build/symfony/demo/.php_cs.dist on line 23
Fatal error: Uncaught Error: Call to undefined method PhpCsFixer\Config::create() in /home/travis/build/symfony/demo/.php_cs.dist:23
Stack trace:
#0 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(931): include()
#1 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(227): PhpCsFixer\Console\ConfigurationResolver::separatedContextLessInclude('/home/travis/bu...')
#2 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(623): PhpCsFixer\Console\ConfigurationResolver->getConfig()
#3 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/ConfigurationResolver.php(456): PhpCsFixer\Console\ConfigurationResolver->getFormat()
#4 /home/travis/build/symfony/demo/vendor/friendsofphp/php-cs-fixer/src/Console/Command/FixCommand.php(154): PhpCsFixer\Console\ConfigurationResolver->getReporter()

@rosier
Copy link
Contributor

rosier commented Sep 12, 2020

I think changing the line

return PhpCsFixer\Config::create()
to return (new PhpCsFixer\Config()) should fix the problem.

For more info see PHP-CS-Fixer/PHP-CS-Fixer#4828

@javiereguiluz
Copy link
Member Author

@rosier yes!! Thanks a lot for your help. Tests are green again!

@javiereguiluz javiereguiluz merged commit e5e5a8f into symfony:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants