Skip to content

CI: Remove "Require symfony/flex" step from tests #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Dec 2, 2022

I think this step can be remove since "symfony/flex" is already part of the project dependencies.

https://github.com/symfony/demo/blob/v2.2.0/composer.json#L28

@stof
Copy link
Member

stof commented Dec 2, 2022

This is not the same than before. As a side effect of that step, we were installing deps (as it does not have --no-update, so the next step was running composer update with the Flex plugin active (and so filtering the Symfony packages based on the version filter). after your change, the composer update runs without the plugin.

@rosier
Copy link
Contributor Author

rosier commented Dec 2, 2022

Looking at the following line I would say that the flex plugin is still active

https://github.com/symfony/demo/actions/runs/3603191289/jobs/6071084273#step:7:133

Is this maybe something that changed with a newer version of composer?

@stof
Copy link
Member

stof commented Dec 2, 2022

Ah, I forgot that recent Flex versions are automatically restarting the composer update when they are installed as part of an update that did not have the filter applied yet.

@javiereguiluz
Copy link
Member

Thanks

@javiereguiluz javiereguiluz merged commit 22af0ca into symfony:main Dec 8, 2022
@rosier rosier deleted the flex branch December 8, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants