Replace AJAX search with Live component #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ker0x
force-pushed
the
feature/blog-search-component
branch
2 times, most recently
from
fc3396b to
41b385e
Compare
|
its a nice idea, following stimulus intro 👍🏻 |
94noni
reviewed
Jan 14, 2023
ker0x
force-pushed
the
feature/blog-search-component
branch
from
41b385e to
10d02fc
Compare
rosier
reviewed
Jan 18, 2023
ker0x
force-pushed
the
feature/blog-search-component
branch
from
10d02fc to
d1c29cb
Compare
94noni
approved these changes
Feb 2, 2023
javiereguiluz
force-pushed
the
feature/blog-search-component
branch
from
d1c29cb to
4d810b7
Compare
|
Romain, thanks a lot for contributing this nice feature. I feared that introducing an UX example would complicate things too much ... but making this change was simply perfect because the result is very nice and it allows to compare traditional JS features vs modern UX-based JS-like features. Thanks to reviewers too 🙏 |
|
Excellent, that's the kind of "real use case" that really shows the power of UX. 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes to replace the AJAX search with a live component example