[Bootstrap v5] Upgrade the bootstrap javascript files from 4.6.2 to 5.3.7 #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosier
changed the title
rosier
commented
Aug 31, 2025
stof
reviewed
Sep 1, 2025
Also upgrade popper from popper.js to @popperjs/core 2.11
|
I wasn't aware this was so bad 😔 Jan, thanks for updating and fixing all this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bootstrap sass files were upgraded to v5, the javascript / importmap files were overlooked and are still at v4.6.2
This PR:
Also the data attributes for all JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, use data-bs-toggle instead of data-toggle.