Skip to content

Stop using Assetic to manage assets #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Stop using Assetic to manage assets #387

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

Related to #386 discussion ... what if we remove Assetic entirely?

@stof
Copy link
Member

stof commented Oct 10, 2016

Fine with me, but we should not force contributors to work on the minified CSS file, so we should replace it with another setup for the assets

@javiereguiluz
Copy link
Member Author

The diff is now impossible to review, but this is what we've done:

  • Removed the source SCSS files and turn them into simple CSS files.
  • Link to *.min.css and *.min.js files for third-party libraries (Bootstrap, jQuery, etc.)
  • Link to main.css and main.js for our app files, so anybody can easily work with them.

@javiereguiluz javiereguiluz changed the title [RFC] Stop using Assetic to manage assets Stop using Assetic to manage assets Oct 12, 2016
guikcd added a commit to guikcd/docker-workshop-advanced that referenced this pull request Nov 15, 2016
@guikcd
Remove assetic from our workshop
ac681d6 
Source: symfony/demo#387
Remove unused swifmail configuration too.
guikcd added a commit to guikcd/docker-workshop-advanced that referenced this pull request Nov 15, 2016
@guikcd
Remove assetic from our workshop
e11a1b5 
Source: symfony/demo#387
Remove unused swiftmailer configuration too.
@guikcd guikcd mentioned this pull request Nov 15, 2016
Merged
@apetitpa apetitpa mentioned this pull request Mar 17, 2017
Merged
javiereguiluz added a commit that referenced this pull request Mar 17, 2017
@javiereguiluz
minor #513 Remove part related to Assetic which is no longer used (ap…
5775c54 
…etitpa)

This PR was merged into the master branch.

Discussion
----------

Remove part related to Assetic which is no longer used

Since #387 Assetic is no longer used to manage assets.

Commits
-------

f9411dc Remove part related to Assetic which is no longer used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Feature FINISHED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javiereguiluz @stof