Skip to content

Updated to Symfony 3.2 BETA1 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Updated to Symfony 3.2 BETA1 #393

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

The beta1 of Symfony 3.2 has just been released, so let's upgrade the Symfony Demo to catch bugs and deprecations before the final release.

@javiereguiluz
Copy link
Member Author

javiereguiluz commented Oct 27, 2016

First deprecation notice discovered after the upgrade:

User Deprecated: The __TwigTemplate_7fa0af8977e9ad6022a4bc7d6829cb425210c6ac6
e9a4fbe673c55e6030063ab::getSource method is deprecated since version 1.27 and will
be removed in 2.0. Use getSourceContext() instead.

@@ -99,15 +99,16 @@ private function getCallableReflector($callable)

private function getTemplateSource(\Twig_Template $template)
{
$templateSource = $template->getSourceContext();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would then update the constraint for Twig to be ^1.27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants