Added an event subscriber to display better error messages in the console #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added the help notes, so this PR can now be reviewed. Thanks! |
bocharsky-bw
reviewed
Jan 6, 2017
| @@ -16,16 +16,37 @@ | |||
| use Symfony\Component\Console\Style\SymfonyStyle; | |||
| use Symfony\Component\EventDispatcher\EventSubscriberInterface; | |||
|
|
|||
| /** | |||
| * This application uses by default a SQLite database to store its information. | |||
There was a problem hiding this comment.
I think it should be an SQLite
Closed
xabbuh
reviewed
Jan 8, 2017
| app.redirect_to_preferred_locale_listener: | ||
| class: AppBundle\EventListener\RedirectToPreferredLocaleListener | ||
| arguments: ['@router', '%app_locales%', '%locale%'] | ||
| tags: | ||
| - { name: kernel.event_listener, event: kernel.request, method: onKernelRequest } | ||
|
|
||
| # Event subscribers are similar to event listeners but they don't need service tags. |
There was a problem hiding this comment.
This reads confusing as you still need to make use of the kernel.event_subscriber tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this PR because:
If you agree, I'll polish this and add some helpful comments: