Use font-awesome icon in "form_errors" block #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voronkovich
reviewed
Jan 6, 2017
| {# use font-awesome icon library #} | ||
| <li><span class="fa fa-exclamation-triangle"></span> {{ error.message }}</li> | ||
| {%- endfor -%} | ||
| </ul> |
There was a problem hiding this comment.
@yceruto, you are missing indentation here
|
@yceruto a very nice catch! Thanks for reporting this problem and solving it elegantly. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 8, 2017
This PR was merged into the master branch. Discussion ---------- Use font-awesome icon in "form_errors" block By default [`bootstrap_3_layout.html.twig` template use `glyphicon-` icon when the `form_errors` block is rendered](https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_layout.html.twig#L259). In this demo app we use font-awesome (`fa-`) icon library, so this PR try to fix that. | Before | After | | ---- | ---- | |  |  | Commits ------- 8b746b6 use font-awesome icon in "form_errors" block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
bootstrap_3_layout.html.twigtemplate useglyphicon-icon when theform_errorsblock is rendered. In this demo app we use font-awesome (fa-) icon library, so this PR try to fix that.