Validate user data before save

[yceruto]

1. I've added a validateUserData method to check for existent user email (this improves a better messages exception) and validate plainPassword and email in non-interactive mode (i.e. $ app:add-user username password email).
2. Renamed the option --is-admin to just --admin, Imho is-admin feels more like a question rather than an instruction. (now $ app:add-user username password email --admin)

Any suggestion is welcome!

[javiereguiluz]

@yceruto thanks for these improvements. I like them. The only question I have is about the --is-admin to --admin reword.

It's true that "is admin" can be understood as a question: "john-doe is admin?" but also as a non-question sentence: "john-doe is admin." In any case, --is-admin is not perfect. However, using just --admin is not perfectly clearly either (it can be understood in several ways in addition to the intended one).

So, let's wait for other opinions before merging it. Thanks!

[yceruto]

As I see it in others commands with similar option, this flag is directly related to the command name rather than its related options, i.e. app:add-user --admin, it's like "I want: to add an admin user", or app:add-user john --admin (add an admin user named john).

This approach in FOSUserBundle commands for example:

• fos:user:create --super-admin --inactive
• fos:user:promote --super

Symfony commands also follow this approach for your flag options, but I'm fine with --is-admin approach too :)

[javiereguiluz]

That's a nice argument. Reusing the existing practices is always a good idea.

[javiereguiluz]

Merged! Thanks for improving this command!