-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Tweaked the new blog post tags feature #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Travis fails with https://travis-ci.org/symfony/symfony-demo/jobs/198778450#L320:
1) Tests\AppBundle\Controller\Admin\BlogControllerTest::testBackendHomepage
The backend homepage displays all the available posts.
Failed asserting that actual size 31 matches expected size 30.
Did you added another post manually?
* | ||
* Execute this command to load the data: | ||
* Defines the sample blog posts to load in the database before running the unit | ||
* and functional tests. Execute this command to load the data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CS expects an endpoint here, maybe should be reverted :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we update the PHPCsFixer to 2.0, we can disable that rule because :
should be valid as the ending of a phrase.
This continues #447 and introduces some minor changes.
The only relevant changes for end users is the minor redesign of the tags. For example, in the blog index, before tags stand out too much and they look like buttons:
Now they are faded because, after all, they are a secondary information:
In the blog post show, the tags are bigger:
And in the admin, I haven't modified anything, so they still look like this: