Skip to content

Tweaked the new blog post tags feature #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Tweaked the new blog post tags feature #448

wants to merge 12 commits into from

Conversation

javiereguiluz
Copy link
Member

This continues #447 and introduces some minor changes.


The only relevant changes for end users is the minor redesign of the tags. For example, in the blog index, before tags stand out too much and they look like buttons:

index-before

Now they are faded because, after all, they are a secondary information:

index-after

In the blog post show, the tags are bigger:

show-after

And in the admin, I haven't modified anything, so they still look like this:

admin-after

Copy link
Member

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Travis fails with https://travis-ci.org/symfony/symfony-demo/jobs/198778450#L320:

1) Tests\AppBundle\Controller\Admin\BlogControllerTest::testBackendHomepage
The backend homepage displays all the available posts.
Failed asserting that actual size 31 matches expected size 30.

Did you added another post manually?

*
* Execute this command to load the data:
* Defines the sample blog posts to load in the database before running the unit
* and functional tests. Execute this command to load the data:
Copy link
Member

@yceruto yceruto Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS expects an endpoint here, maybe should be reverted :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we update the PHPCsFixer to 2.0, we can disable that rule because : should be valid as the ending of a phrase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants