Use dama/doctrine-test-bundle for proper test DB isolation #459
Conversation
phpunit.xml.dist
Outdated
| @@ -28,4 +28,8 @@ | |||
| </exclude> | |||
| </whitelist> | |||
| </filter> | |||
|
|
|||
| <listeners> | |||
| <listener class="\DAMA\DoctrineTestBundle\PHPUnit\PHPUnitStaticDbConnectionListener" file="vendor/dama/doctrine-test-bundle/src/DAMA/DoctrineTestBundle/PHPUnit/PHPUnitStaticDbConnectionListener.php" /> | |||
There was a problem hiding this comment.
Is the file attribute required here? It looks a bit ugly 😢
There was a problem hiding this comment.
You are right 😊 It's not required 👍
|
@javiereguiluz I added a few comments explaining the usage of this bundle. Should I also comment the listener inside |
dmaicher
force-pushed
the
db-test-isolation
branch
from
bf23ef1 to
e90ba4f
Compare
| * | ||
| * Therefore in the following test case we can edit the Post with ID=1 although we deleted it in this test. | ||
| * This test changes the database contents by deleting a blog post. However, | ||
| * thanks to the DAMADoctrineTestBundle and its PRPUnit listener, all changes |
There was a problem hiding this comment.
👍
@dmaicher I've committed some changes directly into your PR. If you make further commits, please don't make a forced push. Thanks!
|
@javiereguiluz changes look good to me 👍 |
|
@dmaicher I'm sorry but when merging other PR, a conflict was created in your composer.lock file. Could you please rebase it? Thanks! |
|
Sure will do it tonight 😉 |
dmaicher
force-pushed
the
db-test-isolation
branch
from
f693779 to
3a94540
Compare
|
@javiereguiluz done 😉 |
|
@dmaicher thanks! I've merged this to test it for real in the application and see how it goes :) |
…on (dmaicher, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Use dama/doctrine-test-bundle for proper test DB isolation This fixes #445 by using https://github.com/dmaicher/doctrine-test-bundle to have proper test isolation. Commits ------- 3a94540 Fixed a typo 172ce3d Tweaks 0fa427c add some comments about the usage of the bundle fc1b7c3 remove file path from listener config d968017 Use dama/doctrine-test-bundle for proper test DB isolation
|
👍 |
This fixes #445 by using https://github.com/dmaicher/doctrine-test-bundle to have proper test isolation.