Skip to content

Enabled the PHP CS rule to fix the file header comment #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Enabled the PHP CS rule to fix the file header comment #511

wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

To avoid issues like #510.

@javiereguiluz
Copy link
Member Author

Now the tests fail because the PHP files in app/ and web/ don't have this header. We won't add it to those files, so how can we solve this?

@apetitpa
Copy link

apetitpa commented Mar 15, 2017

Add ->notPath('web/app_dev.php') etc to $finder in .php_cs file ? But this would exclude those files from other checks. I don't know if this is something acceptable.

@javiereguiluz
Copy link
Member Author

Yes ... but we want the rest of the rules applied to app/ and web/ files :(

@apetitpa
Copy link

apetitpa commented Mar 15, 2017

I don't think there is a way to exclude some checks for a particular path. Maybe this could be a new feature.

@yceruto
Copy link
Member

yceruto commented Mar 15, 2017

@javiereguiluz if we let the license be included in these files?

@javiereguiluz
Copy link
Member Author

@yceruto let's do that because I honestly see no other solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants