Updated the DocBlocks of the Entities #527
Conversation
This PR was merged into the master branch. Discussion ---------- Updated the DocBlocks of the Entities Updated the DocBlocks of the Entities from consistency point of view. Commits ------- e039e60 Updated the DocBlocks of the Entities from consistency point of view.
|
@cafferata thanks for this improvement. In 49d6ded I've removed the empty PHPdoc comments for |
| @@ -91,11 +94,17 @@ public function isLegitComment() | |||
| return !$containsInvalidCharacters; | |||
| } | |||
|
|
|||
| /** | |||
| * @return int | |||
There was a problem hiding this comment.
@javiereguiluz Sorry, it's probably too late, but we don't need these @return statements for getters since we already have it on properties and PhpStorm could resolve them by itself: https://github.com/cafferata/symfony-demo/blob/e039e604a31754e371811b5dba2b0eb738af07fc/src/AppBundle/Entity/Comment.php#L33
But we need them for setters which do not have type hints though.
Some discussion about it here: #394
|
@bocharsky-bw Thanks for pointing this out! Your feedback is appreciated. |
|
@cafferata yes, we should remove those statements as suggested by @bocharsky-bw. |
|
@javiereguiluz I removed the |
|
@cafferata we use a custom tool for merging Symfony PRs ... and I'm afraid I cannot merge the PR again. Maybe you can create a new PR and "cherrypick" your new commit? Thanks! |
|
I think we can just revert this merged PR, since annotations like |
…ency pov" (bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Revert "Updated the DocBlocks of the Entities from consistency pov" This reverts #527 The reasons were described earlier in #394 Commits ------- 88d2100 Revert "Updated the DocBlocks of the Entities from consistency point of view."
Updated the DocBlocks of the Entities from consistency point of view.