Editor preview #528
Editor preview #528
Conversation
|
So this is actually not working as expected. Sorry for the noise.. :( |
|
OK I found the missing piece, even the unit tests are passing now :) This seems to be a pitfall for inexperienced Symfony developers. Not sure what may have caused the misbehavior... |
| $text = $request->request->get('text'); | ||
|
|
||
| if (!$text) { | ||
| $response['data'] = 'Nothing to preview...'; |
There was a problem hiding this comment.
IMO should we return an empty string in this case.
| $response['data'] = $this->get('markdown')->toHtml($text); | ||
| } | ||
|
|
||
| return new JsonResponse($response); |
There was a problem hiding this comment.
You can use $this->json() method to simplify this.
web/js/main.js
Outdated
| preview: function (text, preview, previewUrl) { | ||
| var out = $(preview); | ||
|
|
||
| out.html('Loading preview...'); |
There was a problem hiding this comment.
To avoid the translation issue, you can set this text by default into tab panel preview and translate it then, or use an icon loader instead, in any case this line should be removed.
There was a problem hiding this comment.
I added a CSS loading animation to avoid the translations..
| SymfonyDemo.preview('#post_content', '#previewId', '{{ path('preview') }}'); | ||
| } | ||
| }); | ||
| </script> |
There was a problem hiding this comment.
You can create a template file to do that and avoid duplicated code in edit.html.twig.
| /** | ||
| * Converts a markdown string to HTML. | ||
| * | ||
| * @Route("/preview", name="preview") |
There was a problem hiding this comment.
You can name this route admin_post_content_preview to be consistent with this action and others routes?
| * | ||
| * @author Nikolai Plath <[email protected]> | ||
| */ | ||
| class EditorType extends AbstractType |
There was a problem hiding this comment.
If the only one value here is to override the block name used to render the form type, then use the block_name option instead (bonus plus to this PR) and remove entirely this form type.
For example:
// AppBundle\Form\PostType
->add('content', null, [
// ...
'block_name' => 'editor',
]){# form/fields.html.twig #}
{% block _post_editor_widget %}
...
{{ block('textarea_widget') }}
...
{% endblock %}http://symfony.com/doc/current/reference/forms/types/form.html#block-name
http://symfony.com/doc/current/form/form_customization.html#form-customization-sidebar
http://symfony.com/doc/current/form/form_themes.html#form-template-blocks
|
@yceruto Thanks for the review. Everything makes perfect sense. |
| @@ -18,6 +18,7 @@ | |||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security; | |||
| use Symfony\Bundle\FrameworkBundle\Controller\Controller; | |||
| use Symfony\Component\Form\Extension\Core\Type\SubmitType; | |||
| use Symfony\Component\HttpFoundation\JsonResponse; | |||
There was a problem hiding this comment.
@elkuku, Why do you import this class? You don't use it in the previewAction.
| @@ -18,6 +18,7 @@ | |||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security; | |||
| use Symfony\Bundle\FrameworkBundle\Controller\Controller; | |||
| use Symfony\Component\Form\Extension\Core\Type\SubmitType; | |||
| use Symfony\Component\HttpFoundation\JsonResponse; | |||
|
Thanks @voronkovich and @yceruto seems that your eyes are sharper than any of those automated testing tools :) |
|
Is there anything else I should do here? |
|
Sorry, but I just found #69 😉 |
|
👍🏻 for this, 94noni is my personal account |
|
I'm closing this because we already have an Ajax feature (see #613) and because this would complicate the application too much. Let's remember that we are not making something comparable to WordPress. The blog application is an excuse to show Symfony code. We don't acre about the blog system and we don't care if it doesn't have some features that you find in other CMS or blog systems. @elkuku I'm REALLY sorry for closing this without merging it. I know it's awful to dedicate time to something that it's not merged. That's why I always recommend to open an issue first to discuss about the feature instead of opening a pull request directly. I hope you understand this decision. Thanks! |
This will add an "editor" with preview functionality (as seen on GitHub 😉)
The "lesson" to learn here might be using the markdown service in the controller, making a simple AJAX request and respond with a
JsonResponseobject from the controller.Please bear with me since I am very new to Symfony.
Currently the loading message ("Loading preview...") is hard coded inside the JavaScript file.Does Symfony provide a better way to translate strings in JavaScript files or should I pass the string as a parameter?
Hope you find it useful 😉