Skip to content

Remove title.login_help translation which is unused #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bocharsky-bw
Copy link
Contributor

Actually, we have the same translation message for help.login_users key

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This was updated to <trans-unit id="help.login_users"> but some locales still contained the old translation too. Thanks for fixing this.

@javiereguiluz javiereguiluz merged commit b39918d into symfony:master Apr 21, 2017
javiereguiluz added a commit that referenced this pull request Apr 21, 2017
…rsky-bw)

This PR was merged into the master branch.

Discussion
----------

Remove title.login_help translation which is unused

Actually, we have the same translation message for `help.login_users` key

Commits
-------

b39918d Remove title.login_help translation which is unused
@bocharsky-bw bocharsky-bw deleted the remove-unused-translation branch April 21, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants