Validator service #567
Closed
Validator service #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uikolas
reviewed
May 27, 2017
src/AppBundle/Utils/Validator.php
Outdated
|
|
||
| class Validator | ||
| { | ||
| public function username($username) |
There was a problem hiding this comment.
Maybe the name could be: usernameValidation?
There was a problem hiding this comment.
Finding the "right" name has always been the hardest part in software design 😉
There was a problem hiding this comment.
@elkuku, You're right, but a method name in most cases should be beginning with a verb. :)
This is not a command console but a console command
# Conflicts: # app/config/services.yml
|
This has been updated and corresponding unit tests have been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will move the validator methods in the console commands to a service.
Currently there is a bug caused by the fact that the
delete-usercommand uses a different method to validate the username than theadd-usercommand.So you can actually add a user but you can't remove the user ...
Later in 3.3 this can be nicely injected in the constructordone 😉