Skip to content

Fix autowiring type deprec & use ConsoleEvents::ERROR #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2017

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented May 30, 2017

Relates to symfony/symfony#22951 + use ConsoleEvents::ERROR rather than ConsoleEvents::EXCEPTION

@ogizanagi ogizanagi changed the title Fix some deprecations Fix autowiring type deprec & use ConsoleEvents::ERROR May 30, 2017
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how I missed these in RC1 version!! In any case, thanks for fixing these issues and for improving the console exception too.

@javiereguiluz javiereguiluz merged commit 4ebe39b into symfony:master May 30, 2017
javiereguiluz added a commit that referenced this pull request May 30, 2017
…nagi)

This PR was merged into the master branch.

Discussion
----------

Fix autowiring type deprec & use ConsoleEvents::ERROR

Relates to symfony/symfony#22951 + use `ConsoleEvents::ERROR` rather than `ConsoleEvents::EXCEPTION`

Commits
-------

4ebe39b Fix autowiring type deprec & use ConsoleEvents::ERROR
@ogizanagi ogizanagi deleted the fix/deprecations branch May 30, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants