Fixing add user password validation #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Oct 1, 2017
javiereguiluz
approved these changes
Oct 1, 2017
|
Thanks @chr-hertel. |
javiereguiluz
added a commit
that referenced
this pull request
Oct 1, 2017
This PR was merged into the master branch. Discussion ---------- Fixing add user password validation Fixing password validation in `AddUserCommand`. added type hint to `$io`-var enabling IDE completion to prevent things like that in future changes Commits ------- e9566c0 fixing add user password validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing password validation in
AddUserCommand.added type hint to
$io-var enabling IDE completion to prevent things like that in future changes