Fix Doctrine fixtures service auto-configuration #725
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
Author
|
@phpeek Oops, I don't see your PR, I should have commented on your PR instead, sorry for that. |
Contributor
|
No worries. |
Member
Author
|
closing in favor of #727 |
javiereguiluz
added a commit
that referenced
this pull request
Dec 11, 2017
This PR was squashed before being merged into the master branch (closes #727). Discussion ---------- Revamped the data fixtures After #724 and #725 I realized that our fixtures are not following the modern best practices recommended by DoctrineFixturesBundle ([explained here](https://symfony.com/doc/master/bundles/DoctrineFixturesBundle/index.html)): * Use 1 class to load all fixtures unless you have lots of fixtures. * Make the fixture class extend from Symfony's `Fixture` class instead of the complicated Doctrine's classes. * Inject services in the constructor and rely on autowiring. * etc. Commits ------- adb76fc Revamped the data fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've missed this during the update to DoctrineFixturesBundle 3.0