Including alerts.js and changing loading order #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alerts currently can't be dismissed in the symfony-demo app. Also, updating the loading order to a correct one: https://github.com/twbs/bootstrap-sass#javascript
javiereguiluz
approved these changes
Jan 7, 2018
|
@ptrm04 thanks for fixing these issues with the alerts and congrats on your first Symfony Demo contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jan 8, 2018
This PR was merged into the master branch. Discussion ---------- Including alerts.js and changing loading order Alerts currently can't be dismissed in the symfony-demo app. Also, updating the loading order to a correct one: https://github.com/twbs/bootstrap-sass#javascript Commits ------- 5375d40 Adding .fade and .in to use animation when closing b0ac79c Yarn'd for prod c39d745 Yarn'd after including alert.js 10a7ba8 Fixing a typo 364c6b0 Including alerts.js and changing loading order
|
@javiereguiluz thank you! Looking forward to doing some more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alerts currently can't be dismissed in the symfony-demo app.
Also, updating the loading order to a correct one: https://github.com/twbs/bootstrap-sass#javascript