Keep the services.yaml file in sync with the default Symfony file #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Feb 4, 2018
…ny file (javiereguiluz) This PR was merged into the master branch. Discussion ---------- Keep the services.yaml file in sync with the default Symfony file In this demo app we always keep config files in sync with those provided by the Symfony recipes. This makes the config easier to understand for newcomers (there will be no surprises because when they install Symfony, they'll get the same config they saw on this app). In addition, I think it's a good idea to keep the `App\Controller\` config. It's true that technically we don't need it because our controllers extend from the base controller. But having this config explicitly, makes it easier to understand what's going on with the services created from controllers. Commits ------- 3bb3928 Keep the services.yaml file in sync with the default Symfony file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this demo app we always keep config files in sync with those provided by the Symfony recipes. This makes the config easier to understand for newcomers (there will be no surprises because when they install Symfony, they'll get the same config they saw on this app).
In addition, I think it's a good idea to keep the
App\Controller\config. It's true that technically we don't need it because our controllers extend from the base controller. But having this config explicitly, makes it easier to understand what's going on with the services created from controllers.