-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Updating Yarn dependencies, making build process work again #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Yarn dependencies, making build process work again #857
Conversation
I'm not against replacing |
PR updated, Travis is green. |
@weaverryan quick ping: do you agree replacing |
Hi guys! Hmm, I don't fully agree actually. If we were to have one "default" setting that we should encourage most people to use, it is to USE Configuring the filenames so that the images do not include a hash is something that I think only a minority of users want. If you're using the So actually, I think we should go the other direction - enable versioning :). Cheers! |
(but I like all the other changes - things do need to be updated, from time to time) |
That's fine with me, too. PR updated accordingly. |
Thanks Bob. |
…n (bobdenotter) This PR was merged into the master branch. Discussion ---------- Updating Yarn dependencies, making build process work again Some housekeeping on the Yarn / Encore build process: - Updated `symfony/encore` to `0.20.1` from `0.9.1` - Update a few other deps - Build process is now working again - Changed file naming strategy Note: I replaced this ``` .enableVersioning(false) ``` with this: ``` .configureFilenames({ js: '[name].js', images: 'images/[name].[ext]', fonts: 'fonts/[name].[ext]' }) ``` I did this to keep the delta minimal. Since symfony/webpack-encore#110 `.enableVersioning(false)` is not doing what it says (for understandable reasons), but in this case I chose to keep the filenames without a versioning hash. If you think we should introduce filenames with version hashes instead, i'll happily update this PR. Commits ------- 44d7267 Updating Yarn dependencies, making build process work again
Some housekeeping on the Yarn / Encore build process:
symfony/encore
to0.20.1
from0.9.1
Note: I replaced this
with this:
I did this to keep the delta minimal. Since symfony/webpack-encore#110
.enableVersioning(false)
is not doing what it says (for understandable reasons), but in this case I chose to keep the filenames without a versioning hash. If you think we should introduce filenames with version hashes instead, i'll happily update this PR.