Fix /var configuration in .gitignore #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A better fix would probably be to move the DB elsewhere. But at least, this change is required to make the demo work out of the box. If not, the `var/` directory is not added when doing `git add .` after creating the project with `composer create-project`, which is not what we want.
fabpot
commented
Sep 30, 2018
| @@ -20,7 +20,6 @@ yarn-error.log | |||
| ###> symfony/framework-bundle ### | |||
| /.env | |||
| /public/bundles/ | |||
| /var/ | |||
There was a problem hiding this comment.
/var/* is already excluded a few lines before (but with some other rules afterwards). This one overrides the work done above.
|
Thanks Fabien. |
javiereguiluz
added a commit
that referenced
this pull request
Sep 30, 2018
This PR was merged into the master branch. Discussion ---------- Fix /var configuration in .gitignore A better fix would probably be to move the DB elsewhere. But at least, this change is required to make the demo work out of the box. If not, the `var/` directory is not added when doing `git add .` after creating the project with `composer create-project`, which is not what we want. Commits ------- d760b13 Fix /var configuration in .gitignore
javiereguiluz
added a commit
that referenced
this pull request
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better fix would probably be to move the DB elsewhere.
But at least, this change is required to make the demo work out of the box. If not, the
var/directory is not added when doinggit add .after creating the project withcomposer create-project, which is not what we want.