[make:stimulus-controller] New Stimulus controller Maker command#1075
[make:stimulus-controller] New Stimulus controller Maker command#1075jrushlow merged 3 commits intosymfony:mainfrom
Conversation
1d1d8f0 to
5177550
Compare
make:stimulus-controller
make:stimulus-controller
jrushlow
left a comment
There was a problem hiding this comment.
This is looking real good @JabriAbdelilah! a couple of comments below:
a8782eb to
a963522
Compare
|
@jrushlow @94noni @zairigimad can you re-check, please? |
a963522 to
b4dae5f
Compare
|
|
||
| <info>php %command.full_name% hello</info> | ||
|
|
||
| If the argument is missing, the command will ask for the controller name interactively. No newline at end of file |
There was a problem hiding this comment.
The extension also isnt it?
There was a problem hiding this comment.
Yes I forget to update this file, thanks
There was a problem hiding this comment.
@94noni in fact, the extension is interactive, no need to add it in here
b4dae5f to
7238a67
Compare
update test Coding standards Coding standards Make constants private Add targets and language Respeect Coding Standards Possibility to add values remove extra line
7238a67 to
9086819
Compare
| <?php if ($values) { ?> | ||
| static values = { | ||
| <?php foreach ($values as $value): ?> | ||
| <?= $value['name'] ?>: <?= $value['type'] ?>, |
There was a problem hiding this comment.
just I think the last , is to much no? I mean after the latest value type is written
There was a problem hiding this comment.
That's a trailing comma, it's a good practice in Javascript
|
@jrushlow this PR is ready for review |
jrushlow
left a comment
There was a problem hiding this comment.
Thank you @JabriAbdelilah for the new maker!
New Command to generate Stimulus Controller with targets and values.
test_controller.js
Tickets #809