Skip to content

[make:auth] drop guard support and legacy code cleanup #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2022
Merged

[make:auth] drop guard support and legacy code cleanup #1104

merged 1 commit into from
Apr 26, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 23, 2022 •
edited
Loading

@jrushlow jrushlow changed the title WIP - [make:auth] drop guard support and legacy code cleanup [make:auth] drop guard support and legacy code cleanup Apr 23, 2022
@jrushlow jrushlow added Feature New Feature Status: Needs Review Needs to be reviewed labels Apr 23, 2022
@jrushlow jrushlow mentioned this pull request Apr 25, 2022
Merged
1 task
weaverryan
weaverryan reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments - it'll be great to remove all this old complexity!

src/Maker/MakeAuthenticator.php Outdated
$missingPackagesMessage = 'Twig and symfony/form must be installed to display the login form';
}
$neededDependencies = [TwigBundle::class => 'twig', Form::class => 'symfony/form'];
$missingPackagesMessage = $this->addDependencies($neededDependencies, 'Twig and symfony/form must be installed to display the login form.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember (and it's a bit old and hard to track down) the reason for the if (Kernel::VERSION_ID < 40100) { statement above, but I think you have it backwards. Previously, if the user's version was LESS than 4.1, symfony/form was installed. So, if 4.1 or greater, it is NOT required.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cant remember either and grepping for symfony/form was - well.. ya.. haha removed, we'll see what the tests say..

@jrushlow jrushlow force-pushed the legacy/make-user branch 2 times, most recently from b7154af to 0cf32d3 Compare April 26, 2022 06:36
weaverryan
weaverryan reviewed Apr 26, 2022
View reviewed changes
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 169d46f into symfony:main Apr 26, 2022
@jrushlow jrushlow deleted the legacy/make-user branch April 26, 2022 12:50
weaverryan added a commit that referenced this pull request May 3, 2022
@weaverryan
feature #1107 [make:user] Legacy <= 5.3 & Doctrine Cleanup (jrushlow)
a52f295 
This PR was squashed before being merged into the 1.0-dev branch.

Discussion
----------

[make:user] Legacy <= 5.3 & Doctrine Cleanup

- `TemplateComponentGenerator::generateUseStatements()` can now handle use statements with aliases.
- Add `doctrine/orm` conflict w/ `<2.10`
- drop legacy Symfony < `5.4` Doctrine && User conditionals
- remove legacy `UserBuilder` tests
- fixes #990

- [x] Depends on #1104

Commits
-------

e0c5f2b [make:user] Legacy <= 5.3 & Doctrine Cleanup
@jrushlow jrushlow mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan left review comments

Assignees
No one assigned
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make:auth generates deprecated twig code
2 participants
@jrushlow @weaverryan