Skip to content

[make:*] use sorted use statements#1106

Merged
jrushlow merged 21 commits intosymfony:mainfrom
jrushlow:minor/use-statements
May 3, 2022
Merged

[make:*] use sorted use statements#1106
jrushlow merged 21 commits intosymfony:mainfrom
jrushlow:minor/use-statements

Conversation

@jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 25, 2022

  • removes manual use statements from templates, use statements are generated by UseStatementGenerator
  • remove legacy code and logic from make:command
  • adds the ability to use statements with aliases needed in 1107. e.g. use \Symfony\Something as Else;
  • removes some legacy code from make:registration. Remainder to be removed in [make:user] Legacy <= 5.3 & Doctrine Cleanup #1107

@jrushlow jrushlow added the Minor Minor Enhancement label Apr 25, 2022
@jrushlow jrushlow force-pushed the minor/use-statements branch 2 times, most recently from 716e308 to a1cc88c Compare April 25, 2022 06:12
@jrushlow jrushlow changed the title WIP - [make:*] use sorted use statements [make:*] use sorted use statements Apr 25, 2022
@jrushlow jrushlow force-pushed the minor/use-statements branch from 60148ce to 0b8ed5d Compare April 26, 2022 13:09
@jrushlow jrushlow force-pushed the minor/use-statements branch from 0b8ed5d to 6741a15 Compare April 26, 2022 13:25
@jrushlow jrushlow force-pushed the minor/use-statements branch from 6741a15 to 1426a30 Compare April 26, 2022 13:27
@jrushlow jrushlow added the Status: Needs Review Needs to be reviewed label Apr 28, 2022
Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments!

@jrushlow jrushlow force-pushed the minor/use-statements branch from 3c52311 to e429059 Compare May 2, 2022 17:25
@jrushlow jrushlow merged commit ea27dd1 into symfony:main May 3, 2022
@jrushlow jrushlow deleted the minor/use-statements branch May 3, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor Enhancement Status: Needs Review Needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants