Add missing types in code templates #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
May 2, 2022
| // ->getQuery() | ||
| // ->getResult() | ||
| // ; | ||
| // } |
There was a problem hiding this comment.
sticking to a consistent CS for examples
| { | ||
| // ... | ||
| } | ||
|
|
||
| public static function getSubscribedEvents() | ||
| public static function getSubscribedEvents(): array |
There was a problem hiding this comment.
triggers a deprecation without the return type
| @@ -11,15 +11,15 @@ class <?= $class_name ?> extends Voter | |||
| public const EDIT = 'POST_EDIT'; | |||
| public const VIEW = 'POST_VIEW'; | |||
|
|
|||
| protected function supports(<?= $use_type_hints ? 'string ' : null ?>$attribute, $subject): bool | |||
| protected function supports(string $attribute, $subject): bool | |||
There was a problem hiding this comment.
Kernel is at 5.4 minimum already
| { | ||
| // TODO: return your encoded data | ||
| return ''; | ||
| } | ||
|
|
||
| public function supportsEncoding($format): bool | ||
| public function supportsEncoding(string $format, array $context = []): bool |
There was a problem hiding this comment.
not adding $context is deprecated
| { | ||
| $data = $this->normalizer->normalize($object, $format, $context); | ||
|
|
||
| // Here: add, edit, or delete some data | ||
| // TODO: add, edit, or delete some data |
| */ | ||
| #[\Attribute(\Attribute::TARGET_PROPERTY | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)] |
There was a problem hiding this comment.
because we can, isn't it?
nicolas-grekas
force-pushed
the
types
branch
2 times, most recently
from
ebb2c18 to
f53c858
Compare
jrushlow
reviewed
May 3, 2022
There was a problem hiding this comment.
Looks good! Thanks @nicolas-grekas quick comment on the test return types.
/cc @weaverryan
jrushlow
added
Feature
OskarStark
approved these changes
May 3, 2022
|
Thanks Nicolas! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.