-
-
Notifications
You must be signed in to change notification settings - Fork 424
drop PHP 7.x support #1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
drop PHP 7.x support #1122
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a692d64
require php 8
jrushlow 7b9ef40
[internal] partially implement constructor prop promotion
jrushlow 514ae73
always use typed properties and attributes in generated templates
jrushlow 08ba7b2
[internal] remove route annotation support
jrushlow b35ab23
[ci] wip - remove 7.x tests
jrushlow e257e7f
[internal][make-crud] remove legacy 7.4 tests
jrushlow 21f4862
[internal][make-command] remove legacy 7.4 conditionals
jrushlow 2417e8a
[internal][make:entity] remove annotation tests
jrushlow 53d2b55
[internal][make:reset-password] remove annotation tests
jrushlow d99e159
ci fixes
jrushlow 5d92164
[internal] WIP - remove legacy compat methods
jrushlow 71830c4
fix email verifier property names
jrushlow 4760a70
remove legacy phpcompat methods
jrushlow f868c37
php-cs-fixer it up
jrushlow faa2ca8
cant fully remove the util yet
jrushlow 76e9e1f
cleanup some tests
jrushlow 699c29d
bump appveyor php version
jrushlow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ environment: | |
TEST_DATABASE_DSN: mysql://root:[email protected]:3306/test_maker | ||
matrix: | ||
- dependencies: highest | ||
php_ver_target: 7.2.5 | ||
php_ver_target: 8.0.19 | ||
|
||
install: | ||
- ps: Set-Service wuauserv -StartupType Manual | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,23 +45,18 @@ | |
*/ | ||
final class MakeEntity extends AbstractMaker implements InputAwareMakerInterface | ||
{ | ||
private $fileManager; | ||
private $doctrineHelper; | ||
private $generator; | ||
private $entityClassGenerator; | ||
private $phpCompatUtil; | ||
private Generator $generator; | ||
private EntityClassGenerator $entityClassGenerator; | ||
private PhpCompatUtil $phpCompatUtil; | ||
|
||
public function __construct( | ||
FileManager $fileManager, | ||
DoctrineHelper $doctrineHelper, | ||
private FileManager $fileManager, | ||
private DoctrineHelper $doctrineHelper, | ||
string $projectDirectory = null, | ||
Generator $generator = null, | ||
EntityClassGenerator $entityClassGenerator = null, | ||
PhpCompatUtil $phpCompatUtil = null | ||
) { | ||
$this->fileManager = $fileManager; | ||
$this->doctrineHelper = $doctrineHelper; | ||
|
||
if (null !== $projectDirectory) { | ||
@trigger_error('The $projectDirectory constructor argument is no longer used since 1.41.0', \E_USER_DEPRECATED); | ||
} | ||
|
@@ -877,10 +872,6 @@ private function doesEntityUseAnnotationMapping(string $className): bool | |
/** @legacy Drop when Annotations are no longer supported */ | ||
private function doesEntityUseAttributeMapping(string $className): bool | ||
{ | ||
if (!$this->phpCompatUtil->canUseAttributes()) { | ||
return false; | ||
} | ||
|
||
Comment on lines
872
to
-883
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Handled under a separate PR dedicated to doctrine. |
||
if (!class_exists($className)) { | ||
$otherClassMetadatas = $this->doctrineHelper->getMetadata(Str::getNamespace($className).'\\', true); | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will handle bringing doctrine related makers up to PHP8 standards in a separate PR to avoid too much bloat in this one.