[csm] strict typing && legacy code removal #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
added
Minor
OskarStark
reviewed
May 19, 2022
jrushlow
force-pushed
the
legacy/csm
branch
2 times, most recently
from
bc076ec to
5b0634a
Compare
jrushlow
changed the title
weaverryan
reviewed
May 24, 2022
| sourceCode: $this->fileManager->getFileContents($classPath), | ||
| overwrite: true, | ||
| fluentMutators: true, | ||
| useAttributesForDoctrineMapping: $useAttributesForDoctrineMapping |
There was a problem hiding this comment.
Is this still valid? Like... when would $useAttributesForDoctrineMapping be false... XML? annotations? If annotations, should we throw an exception? If XML... should we throw an exception?
There was a problem hiding this comment.
yes - well kinda, we still need to be able to generate user models if the class isn't an entity. I've added a legacy && todo notation a few lines above to fix the naming conventions in the pr #1128 im working on now.
|
Thanks again Jesse! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drops CSM annotation support
cleans up legacy CSM code
implements strict typing
Depends on drop annotation support with entities #1126