Skip to content

[csm] strict typing && legacy code removal #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented May 18, 2022

@jrushlow jrushlow added Minor Minor Enhancement Feature New Feature and removed Minor Minor Enhancement labels May 18, 2022
@jrushlow jrushlow force-pushed the legacy/csm branch 2 times, most recently from bc076ec to 5b0634a Compare May 24, 2022 14:28
@jrushlow jrushlow changed the title WIP - [csm] strict typing && legacy code removal [csm] strict typing && legacy code removal May 24, 2022
@jrushlow jrushlow added the Status: Needs Review Needs to be reviewed label May 24, 2022
sourceCode: $this->fileManager->getFileContents($classPath),
overwrite: true,
fluentMutators: true,
useAttributesForDoctrineMapping: $useAttributesForDoctrineMapping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still valid? Like... when would $useAttributesForDoctrineMapping be false... XML? annotations? If annotations, should we throw an exception? If XML... should we throw an exception?

Copy link
Collaborator Author

@jrushlow jrushlow May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - well kinda, we still need to be able to generate user models if the class isn't an entity. I've added a legacy && todo notation a few lines above to fix the naming conventions in the pr #1128 im working on now.

@weaverryan
Copy link
Member

Thanks again Jesse!

@weaverryan weaverryan merged commit c02f40a into symfony:main May 26, 2022
@jrushlow jrushlow deleted the legacy/csm branch May 26, 2022 17:43
@jrushlow jrushlow mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants