-
-
Notifications
You must be signed in to change notification settings - Fork 421
[csm] strict typing && legacy code removal #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bc076ec
to
5b0634a
Compare
sourceCode: $this->fileManager->getFileContents($classPath), | ||
overwrite: true, | ||
fluentMutators: true, | ||
useAttributesForDoctrineMapping: $useAttributesForDoctrineMapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still valid? Like... when would $useAttributesForDoctrineMapping
be false... XML? annotations? If annotations, should we throw an exception? If XML... should we throw an exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - well kinda, we still need to be able to generate user models if the class isn't an entity. I've added a legacy && todo notation a few lines above to fix the naming conventions in the pr #1128 im working on now.
Thanks again Jesse! |
drops CSM annotation support
cleans up legacy CSM code
implements strict typing
Depends on drop annotation support with entities #1126