Skip to content

update php-cs-fixer ruleset for php8 #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented May 20, 2022

  • adds the PHP 8 && PHPUnit 8.4 migration rulesets

  • forces trailing commas in multiline parameter lists to improve diff readability. e.g.

public function __construct(
    private int $number,
    private string $word,
)

I also added trailing line commas in multiline argument lists and then reverted the commit. See commit 352f951

If this we should keep multiline trailing commas for args - I'll drop the commit that reverts it. Thoughts @weaverryan @OskarStark @wouterj ?

@weaverryan weaverryan force-pushed the cs/trailing-comma branch from 723c565 to 697071d Compare May 23, 2022 12:41
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit 580fed5 into symfony:main May 23, 2022
@jrushlow jrushlow deleted the cs/trailing-comma branch May 23, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor Enhancement Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants