Skip to content

[make:entity] Improve uid support#1139

Merged
jrushlow merged 2 commits into
symfony:mainfrom
HypeMC:improve-uid-support
Jul 5, 2022
Merged

[make:entity] Improve uid support#1139
jrushlow merged 2 commits into
symfony:mainfrom
HypeMC:improve-uid-support

Conversation

@HypeMC

@HypeMC HypeMC commented Jun 15, 2022

Copy link
Copy Markdown
Member
  1. Currently uuid is offered as the default type when the field name is uuid, which breaks when the symfony/uid component is not installed. Now guid is used when uuid is not available.

  2. Getters & setters for uuid/ulid types now have type hints added when generated.

@HypeMC HypeMC force-pushed the improve-uid-support branch from 3e1036f to c056a83 Compare June 22, 2022 22:29
@jrushlow jrushlow added the Feature New Feature label Jul 5, 2022

@jrushlow jrushlow left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HypeMC

@jrushlow jrushlow merged commit b23178c into symfony:main Jul 5, 2022
@HypeMC HypeMC deleted the improve-uid-support branch July 5, 2022 16:20
@jrushlow jrushlow mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants