Skip to content

EntityRegenerator - no need to set annotations in tests #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 28, 2022

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Dec 28, 2022

We removed entity annotation support in #1126

@jrushlow jrushlow changed the title WIP - support for annotations 2.0 WIP - no more annotations Dec 28, 2022
@@ -61,6 +63,7 @@ public function getPath(): string
* An imperfect, but simple way to check for the presence of an annotation.
*
* @param string $annotation The annotation - e.g. @UniqueEntity
* @deprecated We dont support anntations anymore..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in annotations

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Story of my life 😄 Thanks!

@jrushlow jrushlow added the Minor Minor Enhancement label Dec 28, 2022
@jrushlow jrushlow changed the title WIP - no more annotations EntityRegenerator - no need to set annotations in tests Dec 28, 2022
@jrushlow jrushlow marked this pull request as ready for review December 28, 2022 19:57
@jrushlow jrushlow merged commit ff78148 into symfony:main Dec 28, 2022
@jrushlow jrushlow deleted the fix/annotations branch December 28, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants